Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C.41 compliance: GCS factory constructor. #5393

Merged
merged 4 commits into from
Jan 9, 2025
Merged

C.41 compliance: GCS factory constructor. #5393

merged 4 commits into from
Jan 9, 2025

Conversation

bekadavis9
Copy link
Contributor

Remove GCS::init in favor of a C.41-compliant factory constructor. Use struct GCSParameters to store GCS-specific configuration parameters. Remove Status_GCSError, and replace call sites with throws of GCSException.

[sc-60072]


TYPE: IMPROVEMENT
DESC: C.41 constructor: GCS

Copy link
Member

@teo-tsirpanis teo-tsirpanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bekadavis9 bekadavis9 force-pushed the rd/C41-gcs branch 3 times, most recently from 1478871 to c79709d Compare January 7, 2025 19:44
@teo-tsirpanis
Copy link
Member

CI is green.

@bekadavis9 bekadavis9 merged commit c36bce6 into main Jan 9, 2025
59 checks passed
@bekadavis9 bekadavis9 deleted the rd/C41-gcs branch January 9, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants